remove Proxy entrypoints for canHandleFilter

remove Proxy entrypoints for canHandleFilter

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ded9a6f794a43fc9ec7b370559ba0699c061628d

[reed1, 2015-06-08 21:16:37]

reed@google.com changed reviewers:
+ robertphillips@google.com, senorblanco@google.com

[reed1, 2015-06-08 21:33:52]

The CQ bit was checked by reed@google.com to run a CQ dry run

[reed1, 2015-06-08 21:34:11]

if the dry-run succeeds on chrome, I will remove the guards

[commit-bot: I haz the power, 2015-06-08 21:34:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169923002/20001

[Stephen White, 2015-06-08 21:34:31]

I don't think this change will work. In particular, I think some filters will
render in software after this change, even in GPU mode.

In particular, if the DAG contains a "generic skia" filter such as
SkMergeImageFilter or SkColorFilterImageFilter (which have only an
onFilterImage() override), the proxy
is how the upstream nodes dispatch to GPU processing.

e.g., SkBlurImageFilter -> SkColorFilterImageFilter

Before: cfif->onFilterImage() -> getInput(0)->filterImage() ->
proxy->filterImage() -> SkGpuDevice::filterImage() ->
SkGpuDevice->filterTexture() -> blur->filterImageGPU().

After: cfif->onFilterImage() -> getInput(0)->filterImage() ->
blur->onFilterImage().

[reed1, 2015-06-08 21:36:40]

On 2015/06/08 21:34:31, Stephen White wrote:
> I don't think this change will work. In particular, I think some filters will
> render in software after this change, even in GPU mode.
> 
> In particular, if the DAG contains a "generic skia" filter such as
> SkMergeImageFilter or SkColorFilterImageFilter (which have only an
> onFilterImage() override), the proxy
> is how the upstream nodes dispatch to GPU processing.
> 
> e.g., SkBlurImageFilter -> SkColorFilterImageFilter
> 
> Before: cfif->onFilterImage() -> getInput(0)->filterImage() ->
> proxy->filterImage() -> SkGpuDevice::filterImage() ->
> SkGpuDevice->filterTexture() -> blur->filterImageGPU().
> 
> After: cfif->onFilterImage() -> getInput(0)->filterImage() ->
> blur->onFilterImage().

agreed, simplified the CL for now

[robertphillips, 2015-06-08 21:39:04]

lgtm

[Stephen White, 2015-06-08 21:45:38]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-06-08 21:45:40]

https://codereview.chromium.org/1169923002/diff/20001/src/core/SkDeviceImageF...
File src/core/SkDeviceImageFilterProxy.h (right):

https://codereview.chromium.org/1169923002/diff/20001/src/core/SkDeviceImageF...
src/core/SkDeviceImageFilterProxy.h:34: #ifdef
SK_SUPPORT_LEGACY_PROXY_CANHANDLEIMAGEFILTER
Do we still need the guards? Seems like no one is calling this anymore, and we
can remove it outright, no?

[commit-bot: I haz the power, 2015-06-08 21:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-08 21:47:35]

Dry run: This issue passed the CQ dry run.

[reed2, 2015-06-09 03:00:01]

reed@chromium.org changed reviewers:
+ reed@chromium.org

[reed2, 2015-06-09 03:00:01]

https://codereview.chromium.org/1169923002/diff/20001/src/core/SkDeviceImageF...
File src/core/SkDeviceImageFilterProxy.h (right):

https://codereview.chromium.org/1169923002/diff/20001/src/core/SkDeviceImageF...
src/core/SkDeviceImageFilterProxy.h:34: #ifdef
SK_SUPPORT_LEGACY_PROXY_CANHANDLEIMAGEFILTER
On 2015/06/08 21:45:39, Stephen White wrote:
> Do we still need the guards? Seems like no one is calling this anymore, and we
> can remove it outright, no?

That's why I ran the chrome canaries, to be sure chrome didn't call these
either.

[reed1, 2015-06-09 13:31:17]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-06-09 13:32:42]

The CQ bit was checked by reed@google.com

[reed1, 2015-06-09 13:32:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1169923002/#ps40001
(title: "remove flag")

[commit-bot: I haz the power, 2015-06-09 13:32:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169923002/40001

[commit-bot: I haz the power, 2015-06-09 13:38:54]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ded9a6f794a43fc9ec7b370559ba0699c061628d