Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11699004: Add automated test for chrome.onFileSynced JavsScript event. (Closed)

Created:
7 years, 12 months ago by calvinlo
Modified:
7 years, 11 months ago
Reviewers:
kinuko, benwells
CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add automated test for chrome.onFileSynced JavsScript event. BUG=167739 Test=SyncFileSystemApiTest.OnFileSynced Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175743

Patch Set 1 #

Patch Set 2 : Added JavaScript test dir #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Kinuko Review #1 #

Total comments: 4

Patch Set 5 : Kinuko Review #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 1 2 3 4 3 chunks +31 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/api_test/sync_file_system/on_file_synced/manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/api_test/sync_file_system/on_file_synced/test.js View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
calvinlo
Hi Kinuko San, can you please take a first look at this before I send ...
7 years, 11 months ago (2013-01-08 05:06:03 UTC) #1
kinuko
https://codereview.chromium.org/11699004/diff/6001/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc File chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc (right): https://codereview.chromium.org/11699004/diff/6001/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc#newcode83 chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc:83: fileapi::FileSystemURL mockUrl(*origin, naming: mockUrl -> mock_url (we're in c++!) ...
7 years, 11 months ago (2013-01-08 06:02:37 UTC) #2
calvinlo
Updated. https://codereview.chromium.org/11699004/diff/6001/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc File chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc (right): https://codereview.chromium.org/11699004/diff/6001/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc#newcode83 chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc:83: fileapi::FileSystemURL mockUrl(*origin, On 2013/01/08 06:02:38, kinuko wrote: > ...
7 years, 11 months ago (2013-01-08 08:32:20 UTC) #3
kinuko
lgtm https://codereview.chromium.org/11699004/diff/10001/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc File chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc (right): https://codereview.chromium.org/11699004/diff/10001/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc#newcode75 chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc:75: ACTION_P2(ProcessRemoteChangeAndCallBack, origin, mock_remote_service) { Since this action doesn't ...
7 years, 11 months ago (2013-01-08 12:59:17 UTC) #4
calvinlo
https://codereview.chromium.org/11699004/diff/10001/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc File chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc (right): https://codereview.chromium.org/11699004/diff/10001/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc#newcode75 chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc:75: ACTION_P2(ProcessRemoteChangeAndCallBack, origin, mock_remote_service) { On 2013/01/08 12:59:18, kinuko wrote: ...
7 years, 11 months ago (2013-01-09 04:54:32 UTC) #5
calvinlo
Hi Ben, Kinuko's initial review is done so can you please take a look for ...
7 years, 11 months ago (2013-01-09 04:55:22 UTC) #6
benwells
lgtm
7 years, 11 months ago (2013-01-09 04:59:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/11699004/14001
7 years, 11 months ago (2013-01-09 06:15:08 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 08:19:30 UTC) #9
Message was sent while issue was closed. 
Change committed as 175743

Powered by Google App Engine
This is Rietveld 408576698