Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1169873003: Give the popup menu a 2px border radius (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
jackson_old, Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Give the popup menu a 2px border radius This matches the material design spec. R=ianh@google.com, jackson@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/43e5a636b39ca7742738bc2cada2831224e00201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M sky/sdk/lib/framework/components2/popup_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-09 19:40:03 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-09 19:42:21 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-09 19:43:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
43e5a636b39ca7742738bc2cada2831224e00201 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698