Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1169863002: Sky: Added radial gradients. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -26 lines) Patch
M sky/engine/core/painting/CanvasGradient.h View 1 2 1 chunk +10 lines, -5 lines 0 comments Download
M sky/engine/core/painting/CanvasGradient.cpp View 1 2 chunks +24 lines, -13 lines 0 comments Download
M sky/engine/core/painting/Gradient.dart View 1 2 3 1 chunk +16 lines, -5 lines 0 comments Download
M sky/engine/core/painting/Gradient.idl View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M sky/engine/core/painting/Shader.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sky/examples/raw/painting.sky View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Matt Perry
5 years, 6 months ago (2015-06-08 19:58:17 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-08 21:21:45 UTC) #4
Matt Perry
5 years, 6 months ago (2015-06-09 16:45:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
423c61b4aba3a50b8fd4cc0dbba574a314b11b75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698