Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1169853006: [turbofan] Fix one mean typo in kResolvePossiblyDirectEval. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_trycatch-reducer-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix one mean typo in kResolvePossiblyDirectEval. R=titzer@chromium.org TEST=mjsunit/regress/regress-eval-context Committed: https://crrev.com/f45f24d2595a6bfd8b68fdf37526d5ad3b475c90 Cr-Commit-Position: refs/heads/master@{#28877}

Patch Set 1 #

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-eval-context.js View 1 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-09 15:19:52 UTC) #1
titzer
lgtm Is it possible to have a test that triggers this bug?
5 years, 6 months ago (2015-06-09 15:21:39 UTC) #2
Michael Starzinger
On 2015/06/09 15:21:39, titzer wrote: > lgtm > > Is it possible to have a ...
5 years, 6 months ago (2015-06-09 15:43:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169853006/20001
5 years, 6 months ago (2015-06-09 16:36:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 17:14:51 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 17:14:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f45f24d2595a6bfd8b68fdf37526d5ad3b475c90
Cr-Commit-Position: refs/heads/master@{#28877}

Powered by Google App Engine
This is Rietveld 408576698