Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1169833006: Add metrics for when a cast is started or stopped from the system tray. (Closed)

Created:
5 years, 6 months ago by jdufault
Modified:
5 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metrics for when a cast is started or stopped from the system tray. BUG=433140 Committed: https://crrev.com/584c8eadcb8580822907a11443a9af9aa16d7c96 Cr-Commit-Position: refs/heads/master@{#333854}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M ash/metrics/user_metrics_recorder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/system/cast/tray_cast.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jdufault
Would you mind taking a look? This adds two metrics for the cast system tray ...
5 years, 6 months ago (2015-06-10 19:04:23 UTC) #3
achuithb
lgtm https://codereview.chromium.org/1169833006/diff/1/ash/system/cast/tray_cast.cc File ash/system/cast/tray_cast.cc (right): https://codereview.chromium.org/1169833006/diff/1/ash/system/cast/tray_cast.cc#newcode227 ash/system/cast/tray_cast.cc:227: Shell::GetInstance()->metrics()->RecordUserMetricsAction( nit: Let's make this the last statement ...
5 years, 6 months ago (2015-06-10 19:07:27 UTC) #4
jdufault
https://codereview.chromium.org/1169833006/diff/1/ash/system/cast/tray_cast.cc File ash/system/cast/tray_cast.cc (right): https://codereview.chromium.org/1169833006/diff/1/ash/system/cast/tray_cast.cc#newcode227 ash/system/cast/tray_cast.cc:227: Shell::GetInstance()->metrics()->RecordUserMetricsAction( On 2015/06/10 19:07:27, achuithb wrote: > nit: Let's ...
5 years, 6 months ago (2015-06-10 19:09:41 UTC) #5
Ilya Sherman
actions.xml lgtm
5 years, 6 months ago (2015-06-10 21:14:57 UTC) #6
James Cook
lgtm
5 years, 6 months ago (2015-06-10 23:05:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169833006/20001
5 years, 6 months ago (2015-06-10 23:08:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-11 00:11:26 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 00:12:23 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/584c8eadcb8580822907a11443a9af9aa16d7c96
Cr-Commit-Position: refs/heads/master@{#333854}

Powered by Google App Engine
This is Rietveld 408576698