Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5252)

Unified Diff: chrome/browser/chromeos/policy/power_policy_browsertest.cc

Issue 116983008: chromeos: Don't send empty power management policies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't crash in d'tor if uninitialized Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/power_policy_browsertest.cc
diff --git a/chrome/browser/chromeos/policy/power_policy_browsertest.cc b/chrome/browser/chromeos/policy/power_policy_browsertest.cc
index f5843bc7823825c26b6b2aadd79cdf0f0bb8609e..fddce65d2246d0e234eb011acb2d78fdb70052bb 100644
--- a/chrome/browser/chromeos/policy/power_policy_browsertest.cc
+++ b/chrome/browser/chromeos/policy/power_policy_browsertest.cc
@@ -292,7 +292,7 @@ void PowerPolicyInSessionBrowserTest::SetUpOnMainThread() {
IN_PROC_BROWSER_TEST_F(PowerPolicyLoginScreenBrowserTest,
DISABLED_SetDevicePolicy) {
pm::PowerManagementPolicy power_management_policy =
- power_manager_client_->get_policy();
+ power_manager_client_->policy();
power_management_policy.mutable_ac_delays()->set_screen_dim_ms(5000);
power_management_policy.mutable_ac_delays()->set_screen_off_ms(7000);
power_management_policy.mutable_ac_delays()->set_idle_ms(9000);
@@ -312,7 +312,7 @@ IN_PROC_BROWSER_TEST_F(PowerPolicyLoginScreenBrowserTest,
set_login_screen_power_management(kLoginScreenPowerManagementPolicy);
StoreAndReloadDevicePolicyAndWaitForLoginProfileChange();
EXPECT_EQ(GetDebugString(power_management_policy),
- GetDebugString(power_manager_client_->get_policy()));
+ GetDebugString(power_manager_client_->policy()));
}
// Verifies that device policy is ignored during a session.
@@ -320,14 +320,14 @@ IN_PROC_BROWSER_TEST_F(PowerPolicyLoginScreenBrowserTest,
IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest,
DISABLED_SetDevicePolicy) {
pm::PowerManagementPolicy power_management_policy =
- power_manager_client_->get_policy();
+ power_manager_client_->policy();
em::ChromeDeviceSettingsProto& proto(device_policy()->payload());
proto.mutable_login_screen_power_management()->
set_login_screen_power_management(kLoginScreenPowerManagementPolicy);
StoreAndReloadDevicePolicyAndWaitForLoginProfileChange();
EXPECT_EQ(GetDebugString(power_management_policy),
- GetDebugString(power_manager_client_->get_policy()));
+ GetDebugString(power_manager_client_->policy()));
}
// Verifies that user policy is applied during a session.
@@ -335,7 +335,7 @@ IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest,
IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest,
DISABLED_SetUserPolicy) {
pm::PowerManagementPolicy power_management_policy =
- power_manager_client_->get_policy();
+ power_manager_client_->policy();
power_management_policy.mutable_ac_delays()->set_screen_dim_ms(5000);
power_management_policy.mutable_ac_delays()->set_screen_lock_ms(6000);
power_management_policy.mutable_ac_delays()->set_screen_off_ms(7000);
@@ -385,14 +385,14 @@ IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest,
user_policy_.payload().mutable_waitforinitialuseractivity()->set_value(true);
StoreAndReloadUserPolicy();
EXPECT_EQ(GetDebugString(power_management_policy),
- GetDebugString(power_manager_client_->get_policy()));
+ GetDebugString(power_manager_client_->policy()));
}
// Verifies that screen wake locks can be enabled and disabled by extensions and
// user policy during a session.
IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest, AllowScreenWakeLocks) {
pm::PowerManagementPolicy baseline_policy =
- power_manager_client_->get_policy();
+ power_manager_client_->policy();
// Default settings should have delays.
pm::PowerManagementPolicy power_management_policy = baseline_policy;
@@ -415,24 +415,23 @@ IN_PROC_BROWSER_TEST_F(PowerPolicyInSessionBrowserTest, AllowScreenWakeLocks) {
policy.mutable_battery_delays()->set_screen_dim_ms(0);
policy.mutable_battery_delays()->set_screen_off_ms(0);
policy.set_ac_idle_action(
- power_manager_client_->get_policy().ac_idle_action());
+ power_manager_client_->policy().ac_idle_action());
policy.set_battery_idle_action(
- power_manager_client_->get_policy().battery_idle_action());
- policy.set_reason(power_manager_client_->get_policy().reason());
+ power_manager_client_->policy().battery_idle_action());
+ policy.set_reason(power_manager_client_->policy().reason());
EXPECT_EQ(GetDebugString(policy),
- GetDebugString(power_manager_client_->get_policy()));
+ GetDebugString(power_manager_client_->policy()));
// Engage the user policy and verify that the defaults take effect again.
user_policy_.payload().mutable_allowscreenwakelocks()->set_value(false);
StoreAndReloadUserPolicy();
policy = baseline_policy;
- policy.set_ac_idle_action(
- power_manager_client_->get_policy().ac_idle_action());
+ policy.set_ac_idle_action(power_manager_client_->policy().ac_idle_action());
policy.set_battery_idle_action(
- power_manager_client_->get_policy().battery_idle_action());
- policy.set_reason(power_manager_client_->get_policy().reason());
+ power_manager_client_->policy().battery_idle_action());
+ policy.set_reason(power_manager_client_->policy().reason());
EXPECT_EQ(GetDebugString(policy),
- GetDebugString(power_manager_client_->get_policy()));
+ GetDebugString(power_manager_client_->policy()));
}
} // namespace policy
« no previous file with comments | « no previous file | chrome/browser/chromeos/power/power_prefs.cc » ('j') | chromeos/dbus/fake_power_manager_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698