Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: Source/bindings/v8/IDBBindingUtilitiesTest.cpp

Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | Source/bindings/v8/NPV8Object.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/IDBBindingUtilitiesTest.cpp
diff --git a/Source/bindings/v8/IDBBindingUtilitiesTest.cpp b/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
index 435a2cceb4b9b5b01514f502ad78cd7d20cabf25..b9a00c246cb41508fc4ee9c39fddd6dcfbaa925e 100644
--- a/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
+++ b/Source/bindings/v8/IDBBindingUtilitiesTest.cpp
@@ -107,7 +107,7 @@ TEST_F(IDBKeyFromValueAndKeyPathTest, TopLevelPropertyStringValue)
{
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::Local<v8::Object> object = v8::Object::New(isolate);
- object->Set(v8::String::NewFromUtf8(isolate, "foo"), v8::String::NewFromUtf8(isolate, "zoo"));
+ object->Set(v8AtomicString(isolate, "foo"), v8AtomicString(isolate, "zoo"));
ScriptValue scriptValue(object, isolate);
@@ -119,7 +119,7 @@ TEST_F(IDBKeyFromValueAndKeyPathTest, TopLevelPropertyNumberValue)
{
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::Local<v8::Object> object = v8::Object::New(isolate);
- object->Set(v8::String::NewFromUtf8(isolate, "foo"), v8::Number::New(isolate, 456));
+ object->Set(v8AtomicString(isolate, "foo"), v8::Number::New(isolate, 456));
ScriptValue scriptValue(object, isolate);
@@ -132,8 +132,8 @@ TEST_F(IDBKeyFromValueAndKeyPathTest, SubProperty)
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::Local<v8::Object> object = v8::Object::New(isolate);
v8::Local<v8::Object> subProperty = v8::Object::New(isolate);
- subProperty->Set(v8::String::NewFromUtf8(isolate, "bar"), v8::String::NewFromUtf8(isolate, "zee"));
- object->Set(v8::String::NewFromUtf8(isolate, "foo"), subProperty);
+ subProperty->Set(v8AtomicString(isolate, "bar"), v8AtomicString(isolate, "zee"));
+ object->Set(v8AtomicString(isolate, "foo"), subProperty);
ScriptValue scriptValue(object, isolate);
@@ -148,7 +148,7 @@ TEST_F(InjectIDBKeyTest, TopLevelPropertyStringValue)
{
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::Local<v8::Object> object = v8::Object::New(isolate);
- object->Set(v8::String::NewFromUtf8(isolate, "foo"), v8::String::NewFromUtf8(isolate, "zoo"));
+ object->Set(v8AtomicString(isolate, "foo"), v8AtomicString(isolate, "zoo"));
ScriptValue foozoo(object, isolate);
checkInjection(IDBKey::createString("myNewKey"), foozoo, "bar");
@@ -162,8 +162,8 @@ TEST_F(InjectIDBKeyTest, SubProperty)
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::Local<v8::Object> object = v8::Object::New(isolate);
v8::Local<v8::Object> subProperty = v8::Object::New(isolate);
- subProperty->Set(v8::String::NewFromUtf8(isolate, "bar"), v8::String::NewFromUtf8(isolate, "zee"));
- object->Set(v8::String::NewFromUtf8(isolate, "foo"), subProperty);
+ subProperty->Set(v8AtomicString(isolate, "bar"), v8AtomicString(isolate, "zee"));
+ object->Set(v8AtomicString(isolate, "foo"), subProperty);
ScriptValue scriptObject(object, isolate);
checkInjection(IDBKey::createString("myNewKey"), scriptObject, "foo.baz");
« no previous file with comments | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | Source/bindings/v8/NPV8Object.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698