Source/bindings/v8/V8PerContextData.cpp - Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8PerContextData.cpp

Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8PerContextData.cpp

diff --git a/Source/bindings/v8/V8PerContextData.cpp b/Source/bindings/v8/V8PerContextData.cpp

index 470cd332d7e43fcce60db0c55311b5dda6053cf6..2d4f44fbbd49c9ca5da4545e9bf7e5484b3df089 100644

--- a/Source/bindings/v8/V8PerContextData.cpp

+++ b/Source/bindings/v8/V8PerContextData.cpp

@@ -63,7 +63,7 @@ void V8PerContextData::dispose()

#define V8_STORE_PRIMORDIAL(name, Name) \

{ \

ASSERT(m_##name##Prototype.isEmpty()); \

- v8::Handle<v8::String> symbol = v8::String::NewFromUtf8(m_isolate, #Name, v8::String::kInternalizedString); \

+ v8::Handle<v8::String> symbol = v8AtomicString(m_isolate, #Name); \

if (symbol.IsEmpty()) \

return false; \

v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(v8::Local<v8::Context>::New(m_isolate, m_context)->Global()->Get(symbol)); \