Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp - Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8

Unified Diff: Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp » ('j') | Source/bindings/v8/V8DOMConfiguration.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp b/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

index cf16ed329a1cd52e6a6718efad1a47a12005588a..f4dbcfb9f99c9544868876885a387e02f69a67c9 100644

--- a/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

@@ -215,7 +215,7 @@ static void doNotCheckSecurityVoidMethodOriginSafeMethodGetter(const v8::Propert

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8::String::NewFromUtf8(info.GetIsolate(), "doNotCheckSecurityVoidMethod", v8::String::kInternalizedString));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -267,7 +267,7 @@ static void doNotCheckSecurityPerWorldBindingsVoidMethodOriginSafeMethodGetter(c

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8::String::NewFromUtf8(info.GetIsolate(), "doNotCheckSecurityPerWorldBindingsVoidMethod", v8::String::kInternalizedString));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityPerWorldBindingsVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -319,7 +319,7 @@ static void doNotCheckSecurityPerWorldBindingsVoidMethodOriginSafeMethodGetterFo

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8::String::NewFromUtf8(info.GetIsolate(), "doNotCheckSecurityPerWorldBindingsVoidMethod", v8::String::kInternalizedString));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityPerWorldBindingsVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -371,7 +371,7 @@ static void doNotCheckSecurityReadOnlyVoidMethodOriginSafeMethodGetter(const v8:

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8::String::NewFromUtf8(info.GetIsolate(), "doNotCheckSecurityReadOnlyVoidMethod", v8::String::kInternalizedString));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityReadOnlyVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -423,7 +423,7 @@ static void doNotCheckSecurityUnforgeableVoidMethodOriginSafeMethodGetter(const

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8::String::NewFromUtf8(info.GetIsolate(), "doNotCheckSecurityUnforgeableVoidMethod", v8::String::kInternalizedString));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityUnforgeableVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;