Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 return v8::Local<v8::Value>::New(m_isolate, v8::Undefined(m_isolate)); 536 return v8::Local<v8::Value>::New(m_isolate, v8::Undefined(m_isolate));
537 537
538 v8::Handle<v8::Value> argv[] = { object }; 538 v8::Handle<v8::Value> argv[] = { object };
539 return callDebuggerMethod("getInternalProperties", 1, argv); 539 return callDebuggerMethod("getInternalProperties", 1, argv);
540 } 540 }
541 541
542 v8::Handle<v8::Value> ScriptDebugServer::setFunctionVariableValue(v8::Handle<v8: :Value> functionValue, int scopeNumber, const String& variableName, v8::Handle<v 8::Value> newValue) 542 v8::Handle<v8::Value> ScriptDebugServer::setFunctionVariableValue(v8::Handle<v8: :Value> functionValue, int scopeNumber, const String& variableName, v8::Handle<v 8::Value> newValue)
543 { 543 {
544 v8::Local<v8::Context> debuggerContext = v8::Debug::GetDebugContext(); 544 v8::Local<v8::Context> debuggerContext = v8::Debug::GetDebugContext();
545 if (m_debuggerScript.isEmpty()) 545 if (m_debuggerScript.isEmpty())
546 return m_isolate->ThrowException(v8::String::NewFromUtf8(m_isolate, "Deb ugging is not enabled.")); 546 return m_isolate->ThrowException(v8AtomicString(m_isolate, "Debugging is not enabled."));
547 547
548 v8::Handle<v8::Value> argv[] = { 548 v8::Handle<v8::Value> argv[] = {
549 functionValue, 549 functionValue,
550 v8::Handle<v8::Value>(v8::Integer::New(debuggerContext->GetIsolate(), sc opeNumber)), 550 v8::Handle<v8::Value>(v8::Integer::New(debuggerContext->GetIsolate(), sc opeNumber)),
551 v8String(debuggerContext->GetIsolate(), variableName), 551 v8String(debuggerContext->GetIsolate(), variableName),
552 newValue 552 newValue
553 }; 553 };
554 return callDebuggerMethod("setFunctionVariableValue", 4, argv); 554 return callDebuggerMethod("setFunctionVariableValue", 4, argv);
555 } 555 }
556 556
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
622 { 622 {
623 return PassOwnPtr<ScriptSourceCode>(); 623 return PassOwnPtr<ScriptSourceCode>();
624 } 624 }
625 625
626 String ScriptDebugServer::preprocessEventListener(Frame*, const String& source, const String& url, const String& functionName) 626 String ScriptDebugServer::preprocessEventListener(Frame*, const String& source, const String& url, const String& functionName)
627 { 627 {
628 return source; 628 return source;
629 } 629 }
630 630
631 } // namespace WebCore 631 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698