Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

Issue 116983005: Use v8AtomicString instead of v8::String::NewFromUtf8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 v8::Local<v8::FunctionTemplate> result = data->privateTemplateIfExists(curre ntWorldType, &privateTemplateUniqueKey); 120 v8::Local<v8::FunctionTemplate> result = data->privateTemplateIfExists(curre ntWorldType, &privateTemplateUniqueKey);
121 if (!result.IsEmpty()) 121 if (!result.IsEmpty())
122 return result; 122 return result;
123 123
124 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "BuildDOMTemplate"); 124 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "BuildDOMTemplate");
125 v8::EscapableHandleScope scope(isolate); 125 v8::EscapableHandleScope scope(isolate);
126 result = v8::FunctionTemplate::New(isolate, V8TestInterfaceNamedConstructorC onstructorCallback); 126 result = v8::FunctionTemplate::New(isolate, V8TestInterfaceNamedConstructorC onstructorCallback);
127 127
128 v8::Local<v8::ObjectTemplate> instanceTemplate = result->InstanceTemplate(); 128 v8::Local<v8::ObjectTemplate> instanceTemplate = result->InstanceTemplate();
129 instanceTemplate->SetInternalFieldCount(V8TestInterfaceNamedConstructor::int ernalFieldCount); 129 instanceTemplate->SetInternalFieldCount(V8TestInterfaceNamedConstructor::int ernalFieldCount);
130 result->SetClassName(v8::String::NewFromUtf8(isolate, "TestInterfaceNamedCon structor", v8::String::kInternalizedString)); 130 result->SetClassName(v8AtomicString(isolate, "TestInterfaceNamedConstructor" ));
131 result->Inherit(V8TestInterfaceNamedConstructor::domTemplate(isolate, curren tWorldType)); 131 result->Inherit(V8TestInterfaceNamedConstructor::domTemplate(isolate, curren tWorldType));
132 data->setPrivateTemplate(currentWorldType, &privateTemplateUniqueKey, result ); 132 data->setPrivateTemplate(currentWorldType, &privateTemplateUniqueKey, result );
133 133
134 return scope.Escape(result); 134 return scope.Escape(result);
135 } 135 }
136 136
137 static v8::Handle<v8::FunctionTemplate> ConfigureV8TestInterfaceNamedConstructor Template(v8::Handle<v8::FunctionTemplate> functionTemplate, v8::Isolate* isolate , WrapperWorldType currentWorldType) 137 static v8::Handle<v8::FunctionTemplate> ConfigureV8TestInterfaceNamedConstructor Template(v8::Handle<v8::FunctionTemplate> functionTemplate, v8::Isolate* isolate , WrapperWorldType currentWorldType)
138 { 138 {
139 functionTemplate->ReadOnlyPrototype(); 139 functionTemplate->ReadOnlyPrototype();
140 140
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 fromInternalPointer(object)->deref(); 209 fromInternalPointer(object)->deref();
210 } 210 }
211 211
212 template<> 212 template<>
213 v8::Handle<v8::Value> toV8NoInline(TestInterfaceNamedConstructor* impl, v8::Hand le<v8::Object> creationContext, v8::Isolate* isolate) 213 v8::Handle<v8::Value> toV8NoInline(TestInterfaceNamedConstructor* impl, v8::Hand le<v8::Object> creationContext, v8::Isolate* isolate)
214 { 214 {
215 return toV8(impl, creationContext, isolate); 215 return toV8(impl, creationContext, isolate);
216 } 216 }
217 217
218 } // namespace WebCore 218 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698