Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1169813006: Use SkMScalar as float by default to match Chromium. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SkMScalar as float by default to match Chromium. Tweak some test values to pass with floats. As expected, this regresses matrix44_setconcat_general by about 2x. BUG=skia: Committed: https://skia.googlesource.com/skia/+/519580553ab85ef04c6a08d8e09ef0eb93c7bc1f

Patch Set 1 #

Patch Set 2 : win build #

Patch Set 3 : more win build #

Patch Set 4 : yet more #

Patch Set 5 : rebase #

Patch Set 6 : Tweak some test values to pass with floats. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M include/core/SkPostConfig.h View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/Matrix44Test.cpp View 1 2 3 4 5 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
mtklein_C
5 years, 6 months ago (2015-06-09 15:27:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169813006/1
5 years, 6 months ago (2015-06-09 15:37:33 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1420) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 6 months ago (2015-06-09 15:41:19 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169813006/20001
5 years, 6 months ago (2015-06-09 18:22:06 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169813006/40001
5 years, 6 months ago (2015-06-09 18:26:38 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/1271)
5 years, 6 months ago (2015-06-09 18:30:02 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169813006/60001
5 years, 6 months ago (2015-06-09 18:34:53 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/1274)
5 years, 6 months ago (2015-06-09 18:38:44 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169813006/90001
5 years, 6 months ago (2015-06-09 19:00:53 UTC) #18
mtklein
OK Mike, PTAL.
5 years, 6 months ago (2015-06-09 19:03:39 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-09 19:06:31 UTC) #21
reed1
lgtm
5 years, 6 months ago (2015-06-09 21:25:16 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169813006/90001
5 years, 6 months ago (2015-06-09 22:05:43 UTC) #24
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 22:06:26 UTC) #25
Message was sent while issue was closed. 
Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/519580553ab85ef04c6a08d8e09ef0eb93c7bc1f

Powered by Google App Engine
This is Rietveld 408576698