Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1169813004: Oilpan: Remove a vtable from the Persistent hierarhcy (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, keishi
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Remove a vtable from the Persistent hierarhcy This CL reduces sizeof(Persistent) by 8 byte. BUG=483380 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196751

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M Source/platform/heap/Handle.h View 1 2 8 chunks +16 lines, -16 lines 2 comments Download
M Source/platform/heap/HeapTest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
haraken
PTAL
4 years, 10 months ago (2015-06-09 05:02:42 UTC) #2
haraken
On 2015/06/09 05:02:42, haraken wrote: > PTAL Not yet ready for review. I noticed a ...
4 years, 10 months ago (2015-06-09 05:27:10 UTC) #3
haraken
Fixed the crashes. PTAL. https://codereview.chromium.org/1169813004/diff/40001/Source/platform/heap/Handle.h File Source/platform/heap/Handle.h (left): https://codereview.chromium.org/1169813004/diff/40001/Source/platform/heap/Handle.h#oldcode119 Source/platform/heap/Handle.h:119: // this point. Removed this ...
4 years, 10 months ago (2015-06-09 08:58:42 UTC) #4
keishi
LGTM
4 years, 10 months ago (2015-06-09 09:00:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169813004/40001
4 years, 10 months ago (2015-06-09 09:00:25 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 10:06:26 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196751

Powered by Google App Engine
This is Rietveld 408576698