Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: extensions/renderer/resources/guest_view/extension_view/extension_view_events.js

Issue 1169803006: extensionview: Fix onLoadCommit TypeError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Event management for ExtensionView. 5 // Event management for ExtensionView.
6 6
7 var CreateEvent = require('guestViewEvents').CreateEvent; 7 var CreateEvent = require('guestViewEvents').CreateEvent;
8 var GuestViewEvents = require('guestViewEvents').GuestViewEvents; 8 var GuestViewEvents = require('guestViewEvents').GuestViewEvents;
9 9
10 function ExtensionViewEvents(extensionViewImpl) { 10 function ExtensionViewEvents(extensionViewImpl) {
11 GuestViewEvents.call(this, extensionViewImpl); 11 GuestViewEvents.call(this, extensionViewImpl);
12 } 12 }
13 13
14 ExtensionViewEvents.prototype.__proto__ = GuestViewEvents.prototype; 14 ExtensionViewEvents.prototype.__proto__ = GuestViewEvents.prototype;
15 15
16 ExtensionViewEvents.EVENTS = { 16 ExtensionViewEvents.EVENTS = {
17 'loadcommit': { 17 'loadcommit': {
18 evt: CreateEvent('extensionViewInternal.onLoadCommit'), 18 evt: CreateEvent('extensionViewInternal.onLoadCommit'),
19 handler: 'handleLoadCommitEvent', 19 handler: 'handleLoadCommitEvent',
20 internal: true 20 internal: true
21 } 21 }
22 }; 22 };
23 23
24 ExtensionViewEvents.prototype.getEvents = function() { 24 ExtensionViewEvents.prototype.getEvents = function() {
25 return ExtensionViewEvents.EVENTS; 25 return ExtensionViewEvents.EVENTS;
26 }; 26 };
27 27
28 ExtensionViewEvents.prototype.handleLoadCommitEvent = function(event) { 28 ExtensionViewEvents.prototype.handleLoadCommitEvent = function(event) {
29 this.extensionViewImpl.onLoadCommit(event.url); 29 this.view.onLoadCommit(event.url);
30 }; 30 };
31 31
32 exports.ExtensionViewEvents = ExtensionViewEvents; 32 exports.ExtensionViewEvents = ExtensionViewEvents;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698