Issue 11698005: Adjust fonts (part of 137349): use standard font sizes in chrome/browser/ui/views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11698005: Adjust fonts (part of 137349): use standard font sizes in chrome/browser/ui/views (Closed)

Created:
7 years, 11 months ago by sschmitz

Modified:
7 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Adjust fonts (part of 137349): use standard font sizes in chrome/browser/ui/views Part of work to use standard font sizes instead of "DeriveFont +/- N Pixels". Also per direction of designers and PM to move to Medium non-bold instead of "offsize" bold font for titles and headers. Changed UIs were seen and ok-ed by either sgabriel@ or kuscher@. Please see crbug.com/166679 for details and screenshots BUG=166679, 137349 TEST=manual for sad tab: navigate to chrome://crash for password generation bubble: run with flag --enable-password-generation, navigate to www.target.com and begin to create an account, click on password text box for global error bubble: I modified code in browser.cc to force an error for extension: Chrome Web Store -> Extensitons -> Click on ADD TO CHROME Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175468

Patch Set 1 #

Patch Set 2 : crbug.com/166679 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -59 lines)			Patch
M	chrome/browser/ui/views/extensions/bundle_installed_bubble.cc	View		2 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_dialog_view.cc	View	1	6 chunks	+12 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc	View		3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/global_error_bubble_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/password_generation_bubble_view.cc	View		3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.cc	View		6 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/11698005/2001

7 years, 11 months ago (2013-01-07 22:39:21 UTC) #3

Message was sent while issue was closed.

Change committed as 175468

Expand Messages | Collapse Messages