Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1169743002: Reland "Replace ad-hoc weakness in prototype transitions with WeakCell." (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Replace ad-hoc weakness in prototype transitions with WeakCell." Added missing slots recording. This reverts commit fd2e3344d3116cd9ca11a14a1f4d800effba25ba. BUG= Committed: https://crrev.com/659ea368f754fbf678e376d546b9a4391e6913e5 Cr-Commit-Position: refs/heads/master@{#28857}

Patch Set 1 #

Patch Set 2 : Add missing slots recording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M src/heap/mark-compact.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/transitions.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/transitions.cc View 5 chunks +18 lines, -13 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL. The slots recording was omitted before because maps don't move. Now they replaced by ...
5 years, 6 months ago (2015-06-08 12:01:03 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 6 months ago (2015-06-08 21:37:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169743002/20001
5 years, 6 months ago (2015-06-09 08:22:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 09:00:14 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 09:00:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/659ea368f754fbf678e376d546b9a4391e6913e5
Cr-Commit-Position: refs/heads/master@{#28857}

Powered by Google App Engine
This is Rietveld 408576698