test/cctest/test-heap.cc - Issue 1169733002: Revert of Replace ad-hoc weakness in prototype transitions with WeakCell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 1169733002: Revert of Replace ad-hoc weakness in prototype transitions with WeakCell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index 12ab5102824b0606927d1828b9572657acee8323..a885c4ac03ca60172e8003ab0c662696da950026 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -2466,8 +2466,7 @@

TransitionArray::GetPrototypeTransitions(baseObject->map());

for (int i = initialTransitions; i < initialTransitions + transitions; i++) {

int j = TransitionArray::kProtoTransitionHeaderSize + i;

- CHECK(trans->get(j)->IsWeakCell());

- CHECK(WeakCell::cast(trans->get(j))->value()->IsMap());

+ CHECK(trans->get(j)->IsMap());

}

// Make sure next prototype is placed on an old-space evacuation candidate.

« no previous file with comments | « src/transitions.cc ('k') | no next file » | no next file with comments »