Issue 1169733002: Revert of Replace ad-hoc weakness in prototype transitions with WeakCell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1169733002: Revert of Replace ad-hoc weakness in prototype transitions with WeakCell. (Closed)

Created:
5 years, 6 months ago by ulan

Modified:
5 years, 6 months ago

Reviewers:
Hannes Payer (out of office), Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Replace ad-hoc weakness in prototype transitions with WeakCell. (patchset #2 id:20001 of https://codereview.chromium.org/1163073002/) Reason for revert: GC stress failures. Original issue's description: > Replace ad-hoc weakness in prototype transitions with WeakCell. > > BUG= > > Committed: https://crrev.com/bfb81fbe0d38c88cc1b6ed6eb1a4b8cbe2c469c3 > Cr-Commit-Position: refs/heads/master@{#28830} TBR=jkummerow@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/fd2e3344d3116cd9ca11a14a1f4d800effba25ba Cr-Commit-Position: refs/heads/master@{#28832}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -27 lines)			Patch
M	src/heap/mark-compact.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/heap/objects-visiting-inl.h	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/transitions.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/transitions.cc	View	5 chunks	+13 lines, -18 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

ulan

Created Revert of Replace ad-hoc weakness in prototype transitions with WeakCell.

5 years, 6 months ago (2015-06-08 11:20:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169733002/1

5 years, 6 months ago (2015-06-08 11:20:20 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-08 11:20:46 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fd2e3344d3116cd9ca11a14a1f4d800effba25ba
Cr-Commit-Position: refs/heads/master@{#28832}