Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 116973002: Revert 241085 "[rAc] [OSX] Set tooltip bubble arrow's anchor poi..." (Closed)

Created:
7 years ago by szym
Modified:
7 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 241085 "[rAc] [OSX] Set tooltip bubble arrow's anchor poi..." Suspect of breaking mac autofill tests on main waterfall. > [rAc] [OSX] Set tooltip bubble arrow's anchor point based on the icon location. > > The bubble should always be between the horizontal edges of the dialog. > > BUG=325482 > TEST=(see bug) > R=groby@chromium.org > > Review URL: https://codereview.chromium.org/113763002 TBR=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241092

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
szym
7 years ago (2013-12-17 01:39:06 UTC) #1
szym
Committed patchset #1 manually as r241092.
7 years ago (2013-12-17 01:39:54 UTC) #2
szym
7 years ago (2013-12-17 01:44:18 UTC) #3
Message was sent while issue was closed.
On 2013/12/17 01:39:54, szym wrote:
> Committed patchset #1 manually as r241092.

Sample of failing log:
2013-12-16 17:36:56.528 browser_tests[5493:207] unable to find nib named: (null)
in bundle path: (null)
2013-12-16 17:36:56.529 browser_tests[5493:207] An uncaught exception was raised
2013-12-16 17:36:56.529 browser_tests[5493:207] -[NSViewController loadView]
could not load the "(null)" nib.
2013-12-16 17:36:56.667 browser_tests[5493:207] (
	0   CoreFoundation                      0x9c394b67 __raiseError + 231
	1   libobjc.A.dylib                     0x9b238149 objc_exception_throw + 155
	2   CoreFoundation                      0x9c2fc369 +[NSException
raise:format:arguments:] + 137
	3   CoreFoundation                      0x9c2fc2d9 +[NSException raise:format:]
+ 57
	4   AppKit                              0x963e4dd6 -[NSViewController loadView]
+ 388
	5   AppKit                              0x963e0845 -[NSViewController view] +
42
	6   browser_tests                       0x0199c289 -[AutofillSectionContainer
loadView] + 937
	7   AppKit                              0x963e0845 -[NSViewController view] +
42
	8   browser_tests                       0x0198e6b3 -[AutofillDetailsContainer
loadView] + 739
	9   AppKit                              0x963e0845 -[NSViewController view] +
42
	10  browser_tests                       0x019955bc -[AutofillMainContainer
loadView] + 1036
	11  AppKit                              0x963e0845 -[NSViewController view] +
42
	12  browser_tests                       0x01991d14
-[AutofillDialogWindowController initWithWebContents:dialog:] + 1060
	13  browser_tests                       0x01990175
_ZN8autofill19AutofillDialogCocoa4ShowEv + 197
	14  browser_tests                       0x0193dd77
_ZN8autofill28AutofillDialogControllerImpl4ShowEv + 967
	15  browser_tests                       0x00807947
_ZN8autofill28AutofillDialogControllerTest20InitializeControllerEv + 1287
	16  browser_tests                       0x0135ed70
_ZN20InProcessBrowserTest23RunTestOnMainThreadLoopEv + 176
	17  browser_tests                       0x04acc061
_ZN4base8internal7InvokerILi1ENS0_9BindStateINS0_15RunnableAdapterIMN7content15BrowserTestBaseEFvvEEEFvPS5_ESA_EESA_E3RunEPNS0_13BindStateBaseE
+ 33
	18  browser_tests                       0x00b7870b
_ZN22ChromeBrowserMainParts25PreMainMessageLoopRunImplEv + 6651
	19  browser_tests                       0x00b76c90
_ZN22ChromeBrowserMainParts21PreMainMessageLoopRunEv + 224
	20  browser_tests                       0x03ebd00c
_ZN7content15BrowserMainLoop21PreMainMessageLoopRunEv + 236
	21  browser_tests                       0x03ebedd1
_ZN4base8internal7InvokerILi1ENS0_9BindStateINS0_15RunnableAdapterIMN7content15BrowserMainLoopEFivEEEFiPS5_EFvNS0_17UnretainedWrapperIS5_EEEEESA_E3RunEPNS0_13BindStateBaseE
+ 33
	22  browser_tests                       0x0414346f
_ZN7content17StartupTaskRunner14RunAllTasksNowEv + 47
	23  browser_tests                       0x03ebb8be
_ZN7content15BrowserMainLoop18CreateStartupTasksEv + 878
	24  browser_tests                       0x03ebf65f
_ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE + 511
	25  browser_tests                       0x03eb8f0a
_ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 170
	26  browser_tests                       0x04acbb13
_ZN7content15BrowserTestBase5SetUpEv + 1107
	27  browser_tests                       0x0135dde4
_ZN20InProcessBrowserTest5SetUpEv + 484
	28  browser_tests                       0x0179600a
_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc
+ 186
	29  browser_tests                       0x0178c2e3 _ZN7testing4Test3RunEv + 259
	30  browser_tests                       0x0178d0d1 _ZN7testing8TestInfo3RunEv +
705
	31  browser_tests                       0x0178d4eb _ZN7testing8TestCase3RunEv +
395
	32  browser_tests                       0x0179325b
_ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 1387
	33  browser_tests                       0x0179672a
_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+ 186
	34  browser_tests                       0x01792cdf _ZN7testing8UnitTest3RunEv +
79
	35  browser_tests                       0x01420fd6 _ZN4base9TestSuite3RunEv +
182
	36  browser_tests                       0x0135c6ab
_ZN12_GLOBAL__N_126ChromeTestLauncherDelegate12RunTestSuiteEiPPc + 59
	37  browser_tests                       0x04b0b1ce
_ZN7content11LaunchTestsEPNS_20TestLauncherDelegateEiiPPc + 734
	38  browser_tests                       0x0135c64c _Z17LaunchChromeTestsiiPPc +
60
	39  browser_tests                       0x009f7324 main + 52
	40  browser_tests                       0x0006ef35 start + 53
)

Powered by Google App Engine
This is Rietveld 408576698