Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1169723002: [turbofan] Initial support for the %_DateField intrinsic. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial support for the %_DateField intrinsic. This only introduces better typing and lowering for access to the value field. R=jarin@chromium.org Committed: https://crrev.com/5eafd7a3d95d9ed1e5f1f11a1ea408a1415da2a8 Cr-Commit-Position: refs/heads/master@{#28836}

Patch Set 1 #

Patch Set 2 : Attempt to fix Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-08 10:45:17 UTC) #1
Benedikt Meurer
Hey Jaro, Initial %_DateField steps. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-08 10:46:03 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-08 10:50:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169723002/1
5 years, 6 months ago (2015-06-08 10:51:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/1706) v8_win_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 6 months ago (2015-06-08 11:00:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169723002/20001
5 years, 6 months ago (2015-06-08 11:03:30 UTC) #10
Benedikt Meurer
Committed patchset #2 (id:20001) manually as 5eafd7a3d95d9ed1e5f1f11a1ea408a1415da2a8 (presubmit successful).
5 years, 6 months ago (2015-06-08 11:47:36 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 11:47:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5eafd7a3d95d9ed1e5f1f11a1ea408a1415da2a8
Cr-Commit-Position: refs/heads/master@{#28836}

Powered by Google App Engine
This is Rietveld 408576698