Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1169713004: Allow lax MIME type parsing for same-origin CSS in quirks mode. (Closed)

Created:
4 years, 10 months ago by Mike West
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, rwlbuis, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow lax MIME type parsing for same-origin CSS in quirks mode. The change in [1] is too strict for the web, and doesn't match Firefox or IE's behavior. In particular, it does not respect the same-origin carveout that the HTML spec specifies[2]. This patch corrects that oversight. [1]: https://chromium.googlesource.com/chromium/blink/+/80f95a77030f72e9502f52873eeb4490c4b3f458 [2]: https://html.spec.whatwg.org/multipage/semantics.html#link-type-stylesheet BUG=495711 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196678

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -84 lines) Patch
D LayoutTests/http/tests/misc/css-accept-any-type.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/http/tests/misc/css-accept-any-type-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/security/same-origin-css.html View 2 chunks +9 lines, -9 lines 0 comments Download
A + LayoutTests/http/tests/security/same-origin-css-in-quirks.html View 2 chunks +25 lines, -22 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 2 chunks +3 lines, -13 lines 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
Yoav, Jochen: would one of you mind taking a look at this patch? -mike
4 years, 10 months ago (2015-06-08 13:04:00 UTC) #2
jochen (gone - plz use gerrit)
lgtm with comment https://codereview.chromium.org/1169713004/diff/1/Source/core/fetch/CSSStyleSheetResource.h File Source/core/fetch/CSSStyleSheetResource.h (right): https://codereview.chromium.org/1169713004/diff/1/Source/core/fetch/CSSStyleSheetResource.h#newcode41 Source/core/fetch/CSSStyleSheetResource.h:41: enum MIMETypeCheck { how about an ...
4 years, 10 months ago (2015-06-08 13:35:46 UTC) #3
Mike West
Fixed, as suggested. Also removed http/tests/misc/css-accept-any-type.html, which is entirely redundant with the tests added in ...
4 years, 10 months ago (2015-06-08 14:30:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169713004/20001
4 years, 10 months ago (2015-06-08 14:31:09 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-08 15:49:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196678

Powered by Google App Engine
This is Rietveld 408576698