Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1169673002: Handle UINodes being moved around the Effen tree. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Handle UINodes being moved around the Effen tree. Changes: - Remove all the old tracing logic since that was a lot of code for just random printf debugging and nobody seems to use it - Convert "defunct", a permanent state transition, to "mounted", a state that can be entered and exitted arbitrarily - Coallesce mount/unmount notifications so there's only one per frame - Remove handleRemoved() since we don't use it - Rename a local variable 'parent' to 'ancestor' to avoid shadowing the field - Replace uses of forEach() with for-in Effects: - Reusing a node provided to a constructor in a new place in a tree (especially at a different depth) no longer fails (it used to fail because the node would be marked defunct then remounted later, at which point it would fail) R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1ddf892c641ad2b229752b0b515237e85a354caf

Patch Set 1 #

Patch Set 2 : make it work #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -120 lines) Patch
M sky/sdk/lib/framework/fn2.dart View 16 chunks +92 lines, -120 lines 1 comment Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1169673002/diff/20001/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1169673002/diff/20001/sky/sdk/lib/framework/fn2.dart#newcode71 sky/sdk/lib/framework/fn2.dart:71: _mountedChanged.forEach((UINode node) { for (UINode node in _mountedChanged) ...
5 years, 6 months ago (2015-06-08 16:52:51 UTC) #2
Hixie
5 years, 6 months ago (2015-06-08 16:59:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1ddf892c641ad2b229752b0b515237e85a354caf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698