Chromium Code Reviews
DescriptionHandle UINodes being moved around the Effen tree.
Changes:
- Remove all the old tracing logic since that was a lot of code for
just random printf debugging and nobody seems to use it
- Convert "defunct", a permanent state transition, to "mounted", a
state that can be entered and exitted arbitrarily
- Coallesce mount/unmount notifications so there's only one per frame
- Remove handleRemoved() since we don't use it
- Rename a local variable 'parent' to 'ancestor' to avoid shadowing
the field
- Replace uses of forEach() with for-in
Effects:
- Reusing a node provided to a constructor in a new place in a tree
(especially at a different depth) no longer fails (it used to fail
because the node would be marked defunct then remounted later, at
which point it would fail)
R=abarth@chromium.org
Committed: https://chromium.googlesource.com/external/mojo/+/1ddf892c641ad2b229752b0b515237e85a354caf
Patch Set 1 #Patch Set 2 : make it work #
Total comments: 1
Messages
Total messages: 3 (1 generated)
|
|||||||||||||||||||