Don't run commands that require java unless run_jscompile is true.

Don't run commands that require java unless run_jscompile is true.

R=thakis@chromium.org
BUG=none

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Committed: https://crrev.com/4efc999bee630ba1d2f0ca9f13fcfbef712b1118
Cr-Commit-Position: refs/heads/master@{#333157}

[Dan Beam, 2015-06-05 20:48:07]

dbeam@chromium.org changed reviewers:
+ garykac@chromium.org
- thakis@chromium.org

[Dan Beam, 2015-06-05 20:48:42]

-thakis, +garykac (whoops, swapped you guys)

[garykac, 2015-06-05 21:09:35]

lgtm

https://codereview.chromium.org/1169653002/diff/1/remoting/webapp/build_templ...
File remoting/webapp/build_template.gni (right):

https://codereview.chromium.org/1169653002/diff/1/remoting/webapp/build_templ...
remoting/webapp/build_template.gni:90: if (target_jscompile != "") {
I actually don't like this because it now takes more effort for someone reading
this code to find all the parts affected by the run_jscompile flag. It's now
implicit instead of explicit. Just so we can work around bogus warnings from GN.

but lgtm'ing to unblock Nico

[Dan Beam, 2015-06-05 21:14:52]

https://codereview.chromium.org/1169653002/diff/1/remoting/webapp/build_templ...
File remoting/webapp/build_template.gni (right):

https://codereview.chromium.org/1169653002/diff/1/remoting/webapp/build_templ...
remoting/webapp/build_template.gni:90: if (target_jscompile != "") {
On 2015/06/05 21:09:35, garykac wrote:
> I actually don't like this because it now takes more effort for someone
reading
> this code to find all the parts affected by the run_jscompile flag. It's now
> implicit instead of explicit. Just so we can work around bogus warnings from
GN.
> 
> but lgtm'ing to unblock Nico

I think it reads OK: if there's something to compile, do it.

There's really not a ton of uses of this variable.

[Dan Beam, 2015-06-05 21:15:15]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-06-05 21:15:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169653002/1

[commit-bot: I haz the power, 2015-06-05 22:37:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-05 22:39:29]

Patchset 1 (id:??) landed as
https://crrev.com/4efc999bee630ba1d2f0ca9f13fcfbef712b1118
Cr-Commit-Position: refs/heads/master@{#333157}