Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1169643002: cc: Make unittests use FakePictureLayer instead of FakeContentLayer. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make unittests use FakePictureLayer instead of FakeContentLayer. The latter is going away. Long live Implside painting. This fixes cc/trees/layer_tree_host_unittest_animation.cc, cc/trees/layer_tree_host_unittest_copyrequest.cc and cc/trees/layer_tree_host_common_unittest.cc. R=enne, vmpstr BUG=413479 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4e95f763c7f52664c94373b7d9fcc0ed96c7f019 Cr-Commit-Position: refs/heads/master@{#333111}

Patch Set 1 #

Patch Set 2 : implsidetests: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -113 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 1 3 chunks +4 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 23 chunks +43 lines, -45 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 23 chunks +64 lines, -62 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
danakj
5 years, 6 months ago (2015-06-05 18:02:54 UTC) #1
enne (OOO)
lgtm
5 years, 6 months ago (2015-06-05 18:14:00 UTC) #2
vmpstr
lgtm 2
5 years, 6 months ago (2015-06-05 18:16:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169643002/20001
5 years, 6 months ago (2015-06-05 18:18:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 19:46:33 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:00:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e95f763c7f52664c94373b7d9fcc0ed96c7f019
Cr-Commit-Position: refs/heads/master@{#333111}

Powered by Google App Engine
This is Rietveld 408576698