Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1169623002: Fix visual overflow for LayoutBoxes with numeric border image outsets (Closed)

Created:
4 years, 11 months ago by pdr.
Modified:
4 years, 11 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Fix visual overflow for LayoutBoxes with numeric border image outsets When computing the visual overflow in LayoutBox::addVisualEffectOverflow we would skip adding border image outset overflow because ComputedStyle::hasVisualOverflowingEffect would return false for non-zero numeric outsets. This was caused by a typo in BorderImageLength::isZero (missing '!' before m_number). TEST=fast/borders/border-image-outset.html with slimming paint and SlimmingPaintStrictCullRectClipping enabled. BUG=496319 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/style/BorderImageLength.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
pdr.
4 years, 11 months ago (2015-06-05 05:28:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169623002/1
4 years, 11 months ago (2015-06-05 06:57:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-06-05 07:56:32 UTC) #6
Xianzhu
lgtm
4 years, 11 months ago (2015-06-05 15:55:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169623002/1
4 years, 11 months ago (2015-06-05 15:55:21 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-05 16:20:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196584

Powered by Google App Engine
This is Rietveld 408576698