sky/sdk/lib/framework/fn2.dart - Issue 1169593002: Fix bogus asserts in searchForOldNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/fn2.dart

Issue 1169593002: Fix bogus asserts in searchForOldNode (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/framework/fn2.dart

diff --git a/sky/sdk/lib/framework/fn2.dart b/sky/sdk/lib/framework/fn2.dart

index 14c41e38783487ebb657a3e85b8df7c8b180fcda..f3434de3351594154185326dcda6d1832f228bd0 100644

--- a/sky/sdk/lib/framework/fn2.dart

+++ b/sky/sdk/lib/framework/fn2.dart

@@ -573,7 +573,8 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {

oldNodeIdMap[currentNode._key] = null; // mark it reordered

assert(root is ContainerRenderObjectMixin);

- assert(oldNode.root is ContainerRenderObjectMixin);

+ assert(old.root is ContainerRenderObjectMixin);

+ assert(oldNode.root != null);

old.root.remove(oldNode.root);

root.add(oldNode.root, before: nextSibling);

« no previous file with comments | « no previous file | no next file » | no next file with comments »