Issue 1169593002: Fix bogus asserts in searchForOldNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1169593002: Fix bogus asserts in searchForOldNode (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix bogus asserts in searchForOldNode We should be asserting that old.root is a ContainerRenderObjectMixin because we're able to manipulate its child list. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/ecaff2605f8f3523520f22aef35b7f734d316a8c

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sky/sdk/lib/framework/fn2.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-04 21:59:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ecaff2605f8f3523520f22aef35b7f734d316a8c (presubmit successful).