add callbacks to Images that wrap client-provided content

add callbacks to Images that wrap client-provided content

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/de49988bc24977f97bb1da8c17ceee5432fcc8e7

[reed1, 2015-06-05 13:53:03]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[reed1, 2015-06-05 13:53:04]

Just focusing on the API contract for now... thoughts?

[robertphillips, 2015-06-05 15:57:07]

looks reasonable to me

https://codereview.chromium.org/1169553003/diff/1/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/1169553003/diff/1/include/core/SkImage.h#newc...
include/core/SkImage.h:54: /**
especified?

[bsalomon, 2015-06-11 21:18:38]

API looks good to me. Not sure how we'll handle flushing the image.

image->flushPendingReads();
image->unref();
// hope call back happens!

[reed1, 2015-06-17 13:25:34]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2015-06-17 13:25:34]

https://codereview.chromium.org/1169553003/diff/1/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/1169553003/diff/1/include/core/SkImage.h#newc...
include/core/SkImage.h:54: /**
On 2015/06/05 15:57:06, robertphillips wrote:
> especified?

Done.

[reed1, 2015-06-17 19:43:58]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-17 19:44:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169553003/20001

[commit-bot: I haz the power, 2015-06-17 19:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 19:45:30]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2015-06-17 21:15:38]

moved release management into GrSurface (due to multiple-inheritance
awesomeness)

[reed1, 2015-06-17 21:15:54]

will add raster test next...

[reed1, 2015-06-17 21:15:58]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-17 21:16:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169553003/40001

[reed1, 2015-06-17 21:18:54]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-06-18 20:25:29]

ptal

[reed1, 2015-06-18 20:25:32]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-06-18 20:26:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169553003/80001

[commit-bot: I haz the power, 2015-06-18 20:26:03]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-06-19 02:26 UTC

[bsalomon, 2015-06-18 20:39:13]

otherwise lgtm

https://codereview.chromium.org/1169553003/diff/80001/include/gpu/GrSurface.h
File include/gpu/GrSurface.h (right):

https://codereview.chromium.org/1169553003/diff/80001/include/gpu/GrSurface.h...
include/gpu/GrSurface.h:163: void invokeReleaseProc() {
private?

[reed1, 2015-06-18 20:41:37]

The CQ bit was unchecked by reed@google.com

[commit-bot: I haz the power, 2015-06-18 20:41:45]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/de49988bc24977f97bb1da8c17ceee5432fcc8e7