chrome/browser/ui/simple_message_box_internal.h - Issue 1169503002: Do not record startup metrics when non-browser UI was displayed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/simple_message_box_internal.h

Issue 1169503002: Do not record startup metrics when non-browser UI was displayed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary include statements, override SetUpInProcessBrowserTestFixture instead of Setup. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_SIMPLE_MESSAGE_BOX_INTERNAL_H_

	6 #define CHROME_BROWSER_UI_SIMPLE_MESSAGE_BOX_INTERNAL_H_

	7

	8 namespace chrome {

	9 namespace internal {
	gab 2015/06/16 19:55:34 nit: empty line after namespace declarations typic nit: empty line after namespace declarations typically, i.e. namespace foo { namespace bar { (...) } // namespace bar } // namespace foo (in the .cc file too) tiany 2015/06/23 18:36:35 Done. Show quoted text On 2015/06/16 19:55:34, gab wrote: > nit: empty line after namespace declarations typically, i.e. > > namespace foo { > namespace bar { > > (...) > > } // namespace bar > } // namespace foo > > > (in the .cc file too) Done.
	10 // If true: skips prompting a blocking message box in tests in situations where

	11 // such UI would freeze the test, but behaves as though such a box had come up

	12 // and the user had clicked "OK". Defaults to false.

	13 extern bool g_should_skip_message_box_for_test;

	14 } // namespace internal

	15 } // namespace chrome

	16

	17 #endif // CHROME_BROWSER_UI_SIMPLE_MESSAGE_BOX_INTERNAL_H_

OLD	NEW