Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 1169473003: fixes #43, remove => workaround (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -135 lines) Patch
M lib/runtime/dart/_isolate_helper.js View 4 chunks +10 lines, -10 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/async.js View 21 chunks +43 lines, -43 lines 0 comments Download
M lib/runtime/dart/collection.js View 12 chunks +17 lines, -17 lines 0 comments Download
M lib/runtime/dart/convert.js View 12 chunks +24 lines, -24 lines 0 comments Download
M lib/runtime/dart/isolate.js View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/runtime/harmony_feature_check.js View 1 chunk +1 line, -3 lines 0 comments Download
M lib/src/js/nodes.dart View 2 chunks +1 line, -22 lines 0 comments Download
M lib/src/js/printer.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M test/codegen/expect/BenchmarkBase.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 6 months ago (2015-06-02 21:57:57 UTC) #2
Leaf
lgtm
5 years, 6 months ago (2015-06-02 23:07:32 UTC) #3
Jennifer Messerly
5 years, 6 months ago (2015-06-02 23:30:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19f6daf59b49e425961b01e34ebd50339f8f90a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698