[Toolbar] Use TEXTBUTTON borders.

[Toolbar] Use TEXTBUTTON borders.

R=msw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243670

[Greg Billock, 2013-12-17 01:00:38]

(pending UI approval)

[msw, 2013-12-17 01:02:35]

https://codereview.chromium.org/116943002/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/toolbar_button.cc (left):

https://codereview.chromium.org/116943002/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/toolbar_button.cc:41: const int kHoverImages[] =
IMAGE_GRID(IDR_TOOLBAR_BUTTON_HOVER);
If this is ok, we'll also need to remove the IDRs and image assets themselves!

[Greg Billock, 2014-01-03 21:57:12]

On 2013/12/17 01:02:35, msw wrote:
>
https://codereview.chromium.org/116943002/diff/1/chrome/browser/ui/views/tool...
> File chrome/browser/ui/views/toolbar/toolbar_button.cc (left):
> 
>
https://codereview.chromium.org/116943002/diff/1/chrome/browser/ui/views/tool...
> chrome/browser/ui/views/toolbar/toolbar_button.cc:41: const int kHoverImages[]
=
> IMAGE_GRID(IDR_TOOLBAR_BUTTON_HOVER);
> If this is ok, we'll also need to remove the IDRs and image assets themselves!

Yeah, it looks fine. I'll take out the assets in another change that'll need to
be dcommitted.

[msw, 2014-01-03 22:05:22]

On 2014/01/03 21:57:12, Greg Billock wrote:
> On 2013/12/17 01:02:35, msw wrote:
> >
>
https://codereview.chromium.org/116943002/diff/1/chrome/browser/ui/views/tool...
> > File chrome/browser/ui/views/toolbar/toolbar_button.cc (left):
> > 
> >
>
https://codereview.chromium.org/116943002/diff/1/chrome/browser/ui/views/tool...
> > chrome/browser/ui/views/toolbar/toolbar_button.cc:41: const int
kHoverImages[]
> =
> > IMAGE_GRID(IDR_TOOLBAR_BUTTON_HOVER);
> > If this is ok, we'll also need to remove the IDRs and image assets
themselves!
> 
> Yeah, it looks fine. I'll take out the assets in another change that'll need
to
> be dcommitted.

Do it in this same CL; you can dcommit if needed, but it shouldn't be necessary.

[Greg Billock, 2014-01-06 21:25:31]

On 2014/01/03 22:05:22, msw wrote:
> On 2014/01/03 21:57:12, Greg Billock wrote:
> > On 2013/12/17 01:02:35, msw wrote:
> > >
> >
>
https://codereview.chromium.org/116943002/diff/1/chrome/browser/ui/views/tool...
> > > File chrome/browser/ui/views/toolbar/toolbar_button.cc (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/116943002/diff/1/chrome/browser/ui/views/tool...
> > > chrome/browser/ui/views/toolbar/toolbar_button.cc:41: const int
> kHoverImages[]
> > =
> > > IMAGE_GRID(IDR_TOOLBAR_BUTTON_HOVER);
> > > If this is ok, we'll also need to remove the IDRs and image assets
> themselves!
> > 
> > Yeah, it looks fine. I'll take out the assets in another change that'll need
> to
> > be dcommitted.
> 
> Do it in this same CL; you can dcommit if needed, but it shouldn't be
necessary.

Done.

[msw, 2014-01-06 21:46:40]

LGTM. Great cleanup, thanks!

[Greg Billock, 2014-01-07 18:00:23]

On 2014/01/06 21:46:40, msw wrote:
> LGTM. Great cleanup, thanks!

+cpu for assets owners

[cpu_(ooo_6.6-7.5), 2014-01-08 00:32:50]

lgtm

[commit-bot: I haz the power, 2014-01-08 17:31:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/116943002/120001

[commit-bot: I haz the power, 2014-01-08 22:18:04]

Change committed as 243670