In unoptimized code use call for instanceof instead of inlined checks. This allows us to collect ty…

runtime/lib/object.cc

Index: runtime/lib/object.cc
===================================================================
--- runtime/lib/object.cc	(revision 16547)
+++ runtime/lib/object.cc	(working copy)
@@ -63,6 +63,28 @@
 }
 
 
+DEFINE_NATIVE_ENTRY(Object_instanceOf, 5) {
+  const Instance& instance = Instance::CheckedHandle(arguments->NativeArgAt(0));
+  // Instantiator at pos 1 is not used.

[regis, 2012/12/28 19:46:49]

Do you need it for type feedback? Also, a comment explaining why you need this
call would be useful.

[srdjan, 2013/01/02 20:38:46]

Added comment:
  // Instantiator at position 1 is not used. It is passed along so that the call
  // can be easily converted to an optimized implementation. Instantiator is
  // the used to populate the subtype cache.

Adding comment to object_patch.dart:
  // Call this function instead of inlining instanceof, thus collecting
  // type feedback and reducing code size of unoptimized code. 

+  const AbstractTypeArguments& instantiator_type_arguments =
+      AbstractTypeArguments::CheckedHandle(arguments->NativeArgAt(2));
+  const AbstractType& type =
+      AbstractType::CheckedHandle(arguments->NativeArgAt(3));
+  const Bool& negate = Bool::CheckedHandle(arguments->NativeArgAt(4));
+  ASSERT(type.IsFinalized());
+  Error& malformed_error = Error::Handle();
+  const bool is_instance_of = instance.IsInstanceOf(type,
+                                                    instantiator_type_arguments,
+                                                    &malformed_error);
+  ASSERT(malformed_error.IsNull());

[regis, 2012/12/28 19:46:49]

Instantiating a type with a type argument that is not extending the declared
upper bound results in a malformed type. How can this assert be correct? I
realize you filed a related bug.

[srdjan, 2013/01/02 20:38:46]

Fixed.

+  if (negate.value()) {
+    return is_instance_of ? Bool::False() : Bool::True();
+  } else {
+    return is_instance_of ? Bool::True() : Bool::False();
+  }
+}
+
+
 DEFINE_NATIVE_ENTRY(AbstractType_toString, 1) {
   const AbstractType& type =
       AbstractType::CheckedHandle(arguments->NativeArgAt(0));