base/strings/string_piece.h - Issue 1169393003: Add new SplitString backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_piece.h

Issue 1169393003: Add new SplitString backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/string_piece.h

diff --git a/base/strings/string_piece.h b/base/strings/string_piece.h

index 349018b9d0a25116755ee948f3007d0bba07175e..a83b7d8f661624ff36ee225a8216f33bf26d2529 100644

--- a/base/strings/string_piece.h

+++ b/base/strings/string_piece.h

@@ -18,12 +18,6 @@

// Both of these have the same lifetime semantics. Passing by value

// generates slightly smaller code. For more discussion, Googlers can see

// the thread go/stringpiecebyvalue on c-users.

-//

-// StringPiece16 is similar to StringPiece but for base::string16 instead of

danakj 2015/06/11 23:58:34 This comment doesn't seem wrong or related to the

brettw 2015/06/12 17:37:08 It's wrong. It references when we had two differen

-// std::string. We do not define as large of a subset of the STL functions

-// from basic_string as in StringPiece, but this can be changed if these

-// functions (find, find_first_of, etc.) are found to be useful in this context.

-//

#ifndef BASE_STRINGS_STRING_PIECE_H_

#define BASE_STRINGS_STRING_PIECE_H_

« no previous file with comments | « no previous file | base/strings/string_split.h » ('j') | base/strings/string_split.h » ('J')