Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1169323004: DevTools: do not respect Chrome theme in DevTools, align toolbar items. (Closed)

Created:
5 years, 6 months ago by pfeldman
Modified:
5 years, 6 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: do not respect Chrome theme in DevTools, align toolbar items. NOTRY=true BUG=498750 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196882

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : review comments addressed #

Patch Set 5 : overflow for tab header fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -134 lines) Patch
M Source/devtools/devtools.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D Source/devtools/front_end/Images/toolbarItemSelected.png View 1 2 3 Binary file 0 comments Download
M Source/devtools/front_end/components/DockController.js View 3 chunks +24 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/InspectorView.js View 1 3 chunks +1 line, -7 lines 0 comments Download
M Source/devtools/front_end/components/inspectorViewTabbedPane.css View 1 3 chunks +6 lines, -25 lines 0 comments Download
M Source/devtools/front_end/devtools.js View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 1 chunk +0 lines, -12 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/networkPanel.css View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/sourcesPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
M Source/devtools/front_end/ui/filter.css View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/tabbedPane.css View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/ui/toolbar.css View 1 6 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pfeldman
5 years, 6 months ago (2015-06-10 12:16:01 UTC) #2
pfeldman
PTAL
5 years, 6 months ago (2015-06-10 14:09:03 UTC) #3
dgozman
lgtm https://codereview.chromium.org/1169323004/diff/40001/Source/devtools/front_end/components/inspectorViewTabbedPane.css File Source/devtools/front_end/components/inspectorViewTabbedPane.css (left): https://codereview.chromium.org/1169323004/diff/40001/Source/devtools/front_end/components/inspectorViewTabbedPane.css#oldcode52 Source/devtools/front_end/components/inspectorViewTabbedPane.css:52: -webkit-border-image: url(Images/toolbarItemSelected.png) 0 2 0 2; Remove image. ...
5 years, 6 months ago (2015-06-10 14:43:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169323004/60001
5 years, 6 months ago (2015-06-10 16:10:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169323004/80001
5 years, 6 months ago (2015-06-10 17:48:03 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 17:52:40 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196882

Powered by Google App Engine
This is Rietveld 408576698