Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 11693010: Windows: Remove desktop profile shortcuts (and any others pointing to the exe) on uninstall. (Closed)

Created:
7 years, 11 months ago by Alexei Svitkine (slow)
Modified:
7 years, 11 months ago
Reviewers:
gab, brettw
CC:
chromium-reviews, grt+watch_chromium.org, brettw
Visibility:
Public.

Description

Windows: Remove desktop profile shortcuts (and any others pointing to the exe) on uninstall. BUG=146636 TEST=Uninstalling Chrome removes any present profile shortcuts on the desktop. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174893

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -71 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/setup/install.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/installer/util/shell_util.h View 1 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 4 chunks +51 lines, -36 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 1 6 chunks +39 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Alexei Svitkine (slow)
7 years, 11 months ago (2012-12-28 21:14:19 UTC) #1
gab
This actually does more than the CL description says (i.e. it's not only the profile ...
7 years, 11 months ago (2013-01-02 15:27:02 UTC) #2
Alexei Svitkine (slow)
I forgot to update chrome/installer/setup/uninstall.cc in the previous patch. Can you take another look to ...
7 years, 11 months ago (2013-01-02 16:06:58 UTC) #3
gab
https://codereview.chromium.org/11693010/diff/21001/chrome/installer/setup/uninstall.cc File chrome/installer/setup/uninstall.cc (right): https://codereview.chromium.org/11693010/diff/21001/chrome/installer/setup/uninstall.cc#newcode1066 chrome/installer/setup/uninstall.cc:1066: const FilePath chrome_exe_path( We have an item on the ...
7 years, 11 months ago (2013-01-02 16:12:49 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/11693010/diff/21001/chrome/installer/setup/uninstall.cc File chrome/installer/setup/uninstall.cc (right): https://codereview.chromium.org/11693010/diff/21001/chrome/installer/setup/uninstall.cc#newcode1066 chrome/installer/setup/uninstall.cc:1066: const FilePath chrome_exe_path( On 2013/01/02 16:12:49, gab wrote: > ...
7 years, 11 months ago (2013-01-02 16:15:25 UTC) #5
gab
lgtm
7 years, 11 months ago (2013-01-02 16:16:17 UTC) #6
Alexei Svitkine (slow)
Thanks. +sky for chrome/browser OWNERS
7 years, 11 months ago (2013-01-02 16:17:07 UTC) #7
Alexei Svitkine (slow)
(sky doesn't seem to be around right now...) -sky +brett Brett, could you take a ...
7 years, 11 months ago (2013-01-02 19:07:14 UTC) #8
brettw
lgtm
7 years, 11 months ago (2013-01-02 22:16:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11693010/30003
7 years, 11 months ago (2013-01-02 22:17:04 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-03 00:09:26 UTC) #11
Message was sent while issue was closed.
Change committed as 174893

Powered by Google App Engine
This is Rietveld 408576698