Issue 1169273002: Always use the slimming paint method for implementing SVG shear filters.

Issue 1169273002: Always use the slimming paint method for implementing SVG shear filters. (Closed)

Created:
4 years, 10 months ago by chrishtr

Modified:
4 years, 10 months ago

Reviewers:
pdr.

CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Always use the slimming paint method for implementing SVG shear filters. BUG=446935, 382491 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196891

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	LayoutTests/TestExpectations	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/core/paint/SVGFilterPainter.cpp	View		2 chunks	+2 lines, -5 lines	0 comments	Download

Total messages: 9 (3 generated)

pdr.

LGTM but I think this may result in minor pixel differences.

4 years, 10 months ago (2015-06-09 20:02:34 UTC) #3

chrishtr

On 2015/06/09 at 20:02:34, pdr wrote: > LGTM but I think this may result in ...

4 years, 10 months ago (2015-06-09 20:03:37 UTC) #4

chrishtr

Added rebaseline. Sample result: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/65790/layout-test-results/results.html

4 years, 10 months ago (2015-06-10 18:08:11 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169273002/20001

4 years, 10 months ago (2015-06-10 18:08:32 UTC) #8

commit-bot: I haz the power

4 years, 10 months ago (2015-06-10 19:26:06 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196891