Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1169233002: No toolbar updates while animating tab stack (Closed)

Created:
5 years, 6 months ago by David Trainor- moved to gerrit
Modified:
5 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No toolbar updates while animating tab stack - When leaving the tab switcher, don't update the toolbar button states. This can cause the home button to be displayed early. BUG=497602 Committed: https://crrev.com/d90c1942a225abc638d1b17945e7ad87f93ca914 Cr-Commit-Position: refs/heads/master@{#333575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
David Trainor- moved to gerrit
ptal thanks.
5 years, 6 months ago (2015-06-09 19:11:28 UTC) #2
Ted C
On 2015/06/09 19:11:28, David Trainor wrote: > ptal thanks. lgtm
5 years, 6 months ago (2015-06-09 19:18:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169233002/1
5 years, 6 months ago (2015-06-09 20:52:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 21:20:19 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 21:21:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d90c1942a225abc638d1b17945e7ad87f93ca914
Cr-Commit-Position: refs/heads/master@{#333575}

Powered by Google App Engine
This is Rietveld 408576698