Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
index f95aab7837de94abe677aa76b74c6d36284e892e..33ff28ea3bf61d35e2e7fe73f0e5882163eca485 100644
--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
@@ -7,7 +7,6 @@
#include "base/memory/weak_ptr.h"
#include "components/guest_view/browser/guest_view.h"
-#include "extensions/browser/extension_function_dispatcher.h"
namespace content {
class WebContents;
@@ -50,18 +49,14 @@ class StreamContainer {
base::WeakPtrFactory<StreamContainer> weak_factory_;
};
-class MimeHandlerViewGuest : public guest_view::GuestView<MimeHandlerViewGuest>,
- public ExtensionFunctionDispatcher::Delegate {
+class MimeHandlerViewGuest :
+ public guest_view::GuestView<MimeHandlerViewGuest> {
public:
static guest_view::GuestViewBase* Create(
content::WebContents* owner_web_contents);
static const char Type[];
- // ExtensionFunctionDispatcher::Delegate implementation.
- WindowController* GetExtensionWindowController() const override;
- content::WebContents* GetAssociatedWebContents() const override;
-
// GuestViewBase implementation.
const char* GetAPINamespace() const override;
int GetTaskPrefix() const override;
@@ -96,7 +91,6 @@ class MimeHandlerViewGuest : public guest_view::GuestView<MimeHandlerViewGuest>,
// content::WebContentsObserver implementation.
void DocumentOnLoadCompletedInMainFrame() override;
- bool OnMessageReceived(const IPC::Message& message) override;
std::string view_id() const { return view_id_; }
base::WeakPtr<StreamContainer> GetStream() const;
@@ -106,10 +100,7 @@ class MimeHandlerViewGuest : public guest_view::GuestView<MimeHandlerViewGuest>,
~MimeHandlerViewGuest() override;
private:
- void OnRequest(const ExtensionHostMsg_Request_Params& params);
-
scoped_ptr<MimeHandlerViewGuestDelegate> delegate_;
- scoped_ptr<ExtensionFunctionDispatcher> extension_function_dispatcher_;
scoped_ptr<StreamContainer> stream_;
std::string view_id_;

Powered by Google App Engine
This is Rietveld 408576698