Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.h
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h
index b62d81ab556ec7198ea1a70f26465af8cd9db66b..088c78b0aea16d0045401540dbcb07c57225b32a 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h
@@ -7,7 +7,6 @@
#include "base/macros.h"
#include "components/guest_view/browser/guest_view.h"
-#include "extensions/browser/extension_function_dispatcher.h"
#include "extensions/browser/guest_view/extension_options/extension_options_guest_delegate.h"
#include "url/gurl.h"
@@ -18,8 +17,7 @@ class BrowserContext;
namespace extensions {
class ExtensionOptionsGuest
- : public guest_view::GuestView<ExtensionOptionsGuest>,
- public extensions::ExtensionFunctionDispatcher::Delegate {
+ : public guest_view::GuestView<ExtensionOptionsGuest> {
public:
static const char Type[];
static guest_view::GuestViewBase* Create(
@@ -37,9 +35,6 @@ class ExtensionOptionsGuest
bool IsDragAndDropEnabled() const override;
void OnPreferredSizeChanged(const gfx::Size& pref_size) override;
- // ExtensionFunctionDispatcher::Delegate implementation.
- content::WebContents* GetAssociatedWebContents() const override;
-
// content::WebContentsDelegate implementation.
content::WebContents* OpenURLFromTab(
content::WebContents* source,
@@ -60,15 +55,11 @@ class ExtensionOptionsGuest
void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
- bool OnMessageReceived(const IPC::Message& message) override;
private:
explicit ExtensionOptionsGuest(content::WebContents* owner_web_contents);
~ExtensionOptionsGuest() override;
- void OnRequest(const ExtensionHostMsg_Request_Params& params);
- scoped_ptr<extensions::ExtensionFunctionDispatcher>
- extension_function_dispatcher_;
scoped_ptr<extensions::ExtensionOptionsGuestDelegate>
extension_options_guest_delegate_;
GURL options_page_;

Powered by Google App Engine
This is Rietveld 408576698