Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4169)

Unified Diff: chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc
diff --git a/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc b/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc
index 9a3d14038f248568dac8009e76dad38cb177ad30..ce477434c89dfb6c3b41f59440d7a4c684f83cda 100644
--- a/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc
+++ b/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc
@@ -4,52 +4,17 @@
#include "chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.h"
-#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
-#include "chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h"
-#include "components/pdf/browser/pdf_web_contents_helper.h"
#include "components/renderer_context_menu/context_menu_delegate.h"
-#include "components/ui/zoom/page_zoom.h"
-#include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h"
-
-#if defined(ENABLE_PRINTING)
-#if defined(ENABLE_PRINT_PREVIEW)
-#include "chrome/browser/printing/print_preview_message_handler.h"
-#include "chrome/browser/printing/print_view_manager.h"
-#else
-#include "chrome/browser/printing/print_view_manager_basic.h"
-#endif // defined(ENABLE_PRINT_PREVIEW)
-#endif // defined(ENABLE_PRINTING)
namespace extensions {
-ChromeMimeHandlerViewGuestDelegate::ChromeMimeHandlerViewGuestDelegate(
- MimeHandlerViewGuest* guest)
- : MimeHandlerViewGuestDelegate(guest), guest_(guest) {
+ChromeMimeHandlerViewGuestDelegate::ChromeMimeHandlerViewGuestDelegate() {
}
ChromeMimeHandlerViewGuestDelegate::~ChromeMimeHandlerViewGuestDelegate() {
}
-// TODO(lazyboy): Investigate ways to move this out to /extensions.
-void ChromeMimeHandlerViewGuestDelegate::AttachHelpers() {
- content::WebContents* web_contents = guest_->web_contents();
-#if defined(ENABLE_PRINTING)
-#if defined(ENABLE_PRINT_PREVIEW)
- printing::PrintViewManager::CreateForWebContents(web_contents);
- printing::PrintPreviewMessageHandler::CreateForWebContents(web_contents);
-#else
- printing::PrintViewManagerBasic::CreateForWebContents(web_contents);
-#endif // defined(ENABLE_PRINT_PREVIEW)
-#endif // defined(ENABLE_PRINTING)
- pdf::PDFWebContentsHelper::CreateForWebContentsWithClient(
- web_contents,
- scoped_ptr<pdf::PDFWebContentsHelperClient>(
- new ChromePDFWebContentsHelperClient()));
- extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
- web_contents);
-}
-
bool ChromeMimeHandlerViewGuestDelegate::HandleContextMenu(
content::WebContents* web_contents,
const content::ContextMenuParams& params) {

Powered by Google App Engine
This is Rietveld 408576698