chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc - Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/tab_helper.cc ('K') | « chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h ('k') | chrome/browser/guest_view/extension_view/chrome_extension_view_guest_delegate.h » ('j') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc

diff --git a/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc b/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc

index 4fc170bd06bc6761ac6c6053d83bd2ed070f8484..0685e2b0481d03c784af04d9e1c4eaaf3782dee0 100644

--- a/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc

+++ b/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc

@@ -4,7 +4,6 @@

#include "chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h"

-#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"

#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -21,11 +20,6 @@ ChromeExtensionOptionsGuestDelegate::ChromeExtensionOptionsGuestDelegate(

ChromeExtensionOptionsGuestDelegate::~ChromeExtensionOptionsGuestDelegate() {

}

-void ChromeExtensionOptionsGuestDelegate::DidInitialize() {

- ChromeExtensionWebContentsObserver::CreateForWebContents(

- extension_options_guest()->web_contents());

bool ChromeExtensionOptionsGuestDelegate::HandleContextMenu(

const content::ContextMenuParams& params) {

ContextMenuDelegate* menu_delegate = ContextMenuDelegate::FromWebContents(