Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index fe72e68e1699481aa805c5877ebd62c8502a4d6f..0907b3aa3560bf7fe74419ce1b450d79d4b11cd2 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -362,7 +362,8 @@ void WebViewGuest::DidInitialize(const base::DictionaryValue& create_params) {
if (web_view_guest_delegate_)
web_view_guest_delegate_->OnDidInitialize();
- AttachWebViewHelpers(web_contents());
+ ExtensionsAPIClient::Get()->AttachWebContentsHelpers(web_contents());
+ web_view_permission_helper_.reset(new WebViewPermissionHelper(this));
rules_registry_id_ = GetOrGenerateRulesRegistryID(
owner_web_contents()->GetRenderProcessHost()->GetID(),
@@ -376,12 +377,6 @@ void WebViewGuest::DidInitialize(const base::DictionaryValue& create_params) {
ApplyAttributes(create_params);
}
-void WebViewGuest::AttachWebViewHelpers(WebContents* contents) {
- if (web_view_guest_delegate_)
- web_view_guest_delegate_->OnAttachWebViewHelpers(contents);
- web_view_permission_helper_.reset(new WebViewPermissionHelper(this));
-}
-
void WebViewGuest::ClearDataInternal(base::Time remove_since,
uint32 removal_mask,
const base::Closure& callback) {

Powered by Google App Engine
This is Rietveld 408576698