Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3671)

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest.h

Issue 1169223002: [Extensions] Clean up the handling of ExtensionHostMsg_Request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/app_view/app_view_guest.h
diff --git a/extensions/browser/guest_view/app_view/app_view_guest.h b/extensions/browser/guest_view/app_view/app_view_guest.h
index 4b05d1adb2be8ccbe6c1d5151f0ed24172106d9d..81cf44de0d745606a717b4e6b02be583bc753e99 100644
--- a/extensions/browser/guest_view/app_view/app_view_guest.h
+++ b/extensions/browser/guest_view/app_view/app_view_guest.h
@@ -7,7 +7,6 @@
#include "base/id_map.h"
#include "components/guest_view/browser/guest_view.h"
-#include "extensions/browser/extension_function_dispatcher.h"
#include "extensions/browser/guest_view/app_view/app_view_guest_delegate.h"
namespace extensions {
@@ -18,8 +17,7 @@ class ExtensionHost;
// AppViewGuest is created on attachment. That is, when a guest WebContents is
// associated with a particular embedder WebContents. This happens on calls to
// the connect API.
-class AppViewGuest : public guest_view::GuestView<AppViewGuest>,
- public ExtensionFunctionDispatcher::Delegate {
+class AppViewGuest : public guest_view::GuestView<AppViewGuest> {
public:
static const char Type[];
@@ -33,13 +31,6 @@ class AppViewGuest : public guest_view::GuestView<AppViewGuest>,
static GuestViewBase* Create(content::WebContents* owner_web_contents);
- // ExtensionFunctionDispatcher::Delegate implementation.
- WindowController* GetExtensionWindowController() const override;
- content::WebContents* GetAssociatedWebContents() const override;
-
- // content::WebContentsObserver implementation.
- bool OnMessageReceived(const IPC::Message& message) override;
-
// content::WebContentsDelegate implementation.
bool HandleContextMenu(const content::ContextMenuParams& params) override;
void RequestMediaAccessPermission(
@@ -66,8 +57,6 @@ class AppViewGuest : public guest_view::GuestView<AppViewGuest>,
~AppViewGuest() override;
- void OnRequest(const ExtensionHostMsg_Request_Params& params);
-
void CompleteCreateWebContents(const GURL& url,
const Extension* guest_extension,
const WebContentsCreatedCallback& callback);
@@ -78,7 +67,6 @@ class AppViewGuest : public guest_view::GuestView<AppViewGuest>,
GURL url_;
std::string guest_extension_id_;
- scoped_ptr<ExtensionFunctionDispatcher> extension_function_dispatcher_;
scoped_ptr<AppViewGuestDelegate> app_view_guest_delegate_;
scoped_ptr<AppDelegate> app_delegate_;
« no previous file with comments | « extensions/browser/extensions_browser_client.h ('k') | extensions/browser/guest_view/app_view/app_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698