[Extensions] Clean up the handling of ExtensionHostMsg_Request

extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h"
 
 #include "base/strings/stringprintf.h"
 #include "components/guest_view/common/guest_view_constants.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/host_zoom_map.h"
@@ skipping 64 matching lines @@
 MimeHandlerViewGuest::MimeHandlerViewGuest(
     content::WebContents* owner_web_contents)
     : GuestView<MimeHandlerViewGuest>(owner_web_contents),
       delegate_(ExtensionsAPIClient::Get()->CreateMimeHandlerViewGuestDelegate(
           this)) {
 }
 
 MimeHandlerViewGuest::~MimeHandlerViewGuest() {
 }
 
-WindowController* MimeHandlerViewGuest::GetExtensionWindowController() const {
-  return nullptr;
-}
-
-WebContents* MimeHandlerViewGuest::GetAssociatedWebContents() const {
-  return web_contents();
-}
-
 const char* MimeHandlerViewGuest::GetAPINamespace() const {
   return "mimeHandlerViewGuestInternal";
 }
 
 int MimeHandlerViewGuest::GetTaskPrefix() const {
   return IDS_EXTENSION_TASK_MANAGER_MIMEHANDLERVIEW_TAG_PREFIX;
 }
 
 void MimeHandlerViewGuest::CreateWebContents(
     const base::DictionaryValue& create_params,
@@ skipping 45 matching lines @@
 void MimeHandlerViewGuest::DidAttachToEmbedder() {
   web_contents()->GetController().LoadURL(
       stream_->handler_url(), content::Referrer(),
       ui::PAGE_TRANSITION_AUTO_TOPLEVEL, std::string());
   web_contents()->GetMainFrame()->GetServiceRegistry()->AddService(
       base::Bind(&MimeHandlerServiceImpl::Create, stream_->GetWeakPtr()));
 }
 
 void MimeHandlerViewGuest::DidInitialize(
     const base::DictionaryValue& create_params) {
-  extension_function_dispatcher_.reset(
-      new ExtensionFunctionDispatcher(browser_context(), this));
-  if (delegate_)
-    delegate_->AttachHelpers();
+  ExtensionsAPIClient::Get()->AttachWebContentsHelpers(web_contents());

[not at google - send to devlin, 2015/06/10 18:37:49]

It seems like this belongs in the GuestView base class, since guest view relies
on extension bindings to work. In fact many of these GuestView::DidInitialize
implementations *only* call AttachWebContentsHelpers(), so you could remove
those.

I'll let fsamuel@ comment on this, though.

[Devlin, 2015/06/10 20:59:20]

The only concern is that it would introduce a dependency from
components/guest_view to extensions, or would require wiring up (another)
delegate to this.  If we decide to do it (which I'd be fine with - it would be a
nice little clean up), I'd probably want to push it to a separate patch, if
that's okay (as is, this will still clean up quite a bit of code and introduces
no new dependencies).

 }
 
 bool MimeHandlerViewGuest::ZoomPropagatesFromEmbedderToGuest() const {
   return false;
 }
 
 bool MimeHandlerViewGuest::Find(int request_id,
                                 const base::string16& search_text,
                                 const blink::WebFindOptions& options) {
   if (is_full_page_plugin()) {
@@ skipping 72 matching lines @@
                                      referrer);
   return true;
 }
 
 void MimeHandlerViewGuest::DocumentOnLoadCompletedInMainFrame() {
   embedder_web_contents()->Send(
       new ExtensionsGuestViewMsg_MimeHandlerViewGuestOnLoadCompleted(
           element_instance_id()));
 }
 
-bool MimeHandlerViewGuest::OnMessageReceived(const IPC::Message& message) {
-  bool handled = true;
-  IPC_BEGIN_MESSAGE_MAP(MimeHandlerViewGuest, message)
-    IPC_MESSAGE_HANDLER(ExtensionHostMsg_Request, OnRequest)
-    IPC_MESSAGE_UNHANDLED(handled = false)
-  IPC_END_MESSAGE_MAP()
-  return handled;
-}
-
 base::WeakPtr<StreamContainer> MimeHandlerViewGuest::GetStream() const {
   if (!stream_)
     return base::WeakPtr<StreamContainer>();
   return stream_->GetWeakPtr();
 }
 
-void MimeHandlerViewGuest::OnRequest(
-    const ExtensionHostMsg_Request_Params& params) {
-  if (extension_function_dispatcher_) {
-    extension_function_dispatcher_->Dispatch(
-        params, web_contents()->GetRenderViewHost());
-  }
-}
-
 }  // namespace extensions