cc: Always call PrepareTiles on visibility change.

cc: Always call PrepareTiles on visibility change.

When using SingleThreadProxy with impl side painting the scheduler waits
for the READY_TO_DRAW signal indefinitely. If renderer switches from
visible to invisible and back again it gets in a state where it won't
ever call PrepareTiles and not advance frames indefinitely. Calling
PrepareTiles unconditionally on visiblity changes fixes that.

BUG=497473
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/eff4a1edd1c0daa259b548c90216b6892e772a2f
Cr-Commit-Position: refs/heads/master@{#333576}

[sunnyps, 2015-06-09 18:59:48]

sunnyps@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[sunnyps, 2015-06-09 18:59:49]

PTAL

[enne (OOO), 2015-06-09 19:06:36]

Does this manual PrepareTiles need to drain the PrepareTiles funnel? Or is that
a separate patch?

[sunnyps, 2015-06-09 19:09:45]

On 2015/06/09 19:06:36, enne wrote:
> Does this manual PrepareTiles need to drain the PrepareTiles funnel? Or is
that
> a separate patch?

The funnel wasn't really responsible for the bug. The worst the funnel does is
delay the PrepareTiles on draw by one frame. I think we should fix that too by
draining the funnel completely on visibility / begin frame changes but that
would be a separate patch.

[enne (OOO), 2015-06-09 19:56:23]

lgtm

On 2015/06/09 at 19:09:45, sunnyps wrote:
> On 2015/06/09 19:06:36, enne wrote:
> > Does this manual PrepareTiles need to drain the PrepareTiles funnel? Or is
that
> > a separate patch?
> 
> The funnel wasn't really responsible for the bug. The worst the funnel does is
delay the PrepareTiles on draw by one frame. I think we should fix that too by
draining the funnel completely on visibility / begin frame changes but that
would be a separate patch.

Sounds good to me.  Just wanted to make sure I understood the thinking here.  :)

[sunnyps, 2015-06-09 20:08:27]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2015-06-09 20:09:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169213002/1

[commit-bot: I haz the power, 2015-06-09 21:25:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-09 21:26:07]

Patchset 1 (id:??) landed as
https://crrev.com/eff4a1edd1c0daa259b548c90216b6892e772a2f
Cr-Commit-Position: refs/heads/master@{#333576}