Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: components/omnibox/autocomplete_match.h

Issue 1169173005: Omnibox - Mark As Duplicates URLs that only differ by a trailing slash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor improvements Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/omnibox/autocomplete_match.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/autocomplete_match.h
diff --git a/components/omnibox/autocomplete_match.h b/components/omnibox/autocomplete_match.h
index 0464d73ac275e41a2c753bc5a6925828ddc70cbd..563100e94a5cf8a11830239f2e551c58f87eda33 100644
--- a/components/omnibox/autocomplete_match.h
+++ b/components/omnibox/autocomplete_match.h
@@ -175,15 +175,15 @@ struct AutocompleteMatch {
const std::string& host);
// Returns |url| altered by stripping off "www.", converting https protocol
- // to http, and stripping excess query parameters. These conversions are
- // merely to allow comparisons to remove likely duplicates; these URLs are
- // not used as actual destination URLs. If |template_url_service| is not
- // NULL, it is used to get a template URL corresponding to this match. If
- // the match's keyword is known, it can be passed in. Otherwise, it can be
- // left empty and the template URL (if any) is determined from the
- // destination's hostname. The template URL is used to strip off query args
- // other than the search terms themselves that would otherwise prevent doing
- // proper deduping.
+ // to http, normalizing trailing slashes, and stripping excess query
+ // parameters. These conversions are merely to allow comparisons to remove
+ // likely duplicates; these URLs are not used as actual destination URLs.
+ // If |template_url_service| is not NULL, it is used to get a template URL
+ // corresponding to this match. If the match's keyword is known, it can be
+ // passed in. Otherwise, it can be left empty and the template URL (if any)
+ // is determined from the destination's hostname. The template URL is used
+ // to strip off query args other than the search terms themselves that would
+ // otherwise prevent doing proper deduping.
static GURL GURLToStrippedGURL(const GURL& url,
TemplateURLService* template_url_service,
const base::string16& keyword);
@@ -307,7 +307,7 @@ struct AutocompleteMatch {
// It may be empty if there is no possible navigation.
GURL destination_url;
- // The destination URL with "www." stripped off for better dupe finding.
+ // The destination URL, somewhat normalized for better dupe finding.
GURL stripped_destination_url;
// The main text displayed in the address bar dropdown.
« no previous file with comments | « no previous file | components/omnibox/autocomplete_match.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698