Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1169143003: Add initial support for runtime permissions in android M. (Closed)

Created:
5 years, 6 months ago by Ted C
Modified:
5 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, markusheintz_, wjia+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

Add initial support for runtime permissions in android M. After clicking the "Allow" button in the infobars, Chrome will request the permission if required from Android. BUG=496447 Review URL: https://codereview.chromium.org/1164973003 Cr-Commit-Position: refs/heads/master@{#333663} Committed: https://chromium.googlesource.com/chromium/src/+/1750d68f2b32c8f8e41fcf9f8f0fbe29c8e1fac0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -31 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java View 3 chunks +113 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBarDelegate.java View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_infobar_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/content_settings/permission_infobar_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/infobars/confirm_infobar.cc View 2 chunks +39 lines, -3 lines 0 comments Download
M components/infobars/core/infobar_delegate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/infobars/core/infobar_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java View 4 chunks +10 lines, -9 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 2 chunks +1 line, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java View 7 chunks +80 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/base/WindowAndroid.java View 3 chunks +27 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ted C
5 years, 6 months ago (2015-06-10 17:59:35 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1750d68f2b32c8f8e41fcf9f8f0fbe29c8e1fac0.

Powered by Google App Engine
This is Rietveld 408576698