[deoptimizer] Basic support inlining based on SharedFunctionInfo.

[deoptimizer] Basic support inlining based on SharedFunctionInfo.

Up until now we can only inline based on JSFunction, because of the way
the deoptimization works.  With this change we will be able to inline
based on the SharedFunctionInfo and materialize the JSFunction from a
literal or a stack slot when necessary.

R=jarin@chromium.org

Committed: https://crrev.com/cf21da7e485ac80b3071e477e5399a00ee2b365f
Cr-Commit-Position: refs/heads/master@{#28906}

[Benedikt Meurer, 2015-06-10 10:46:04]

Hey Jaro,

This is the initial CL for inlining with SharedFunctionInfo. Please take a look.

Thanks,
Benedikt

[Jarin, 2015-06-10 11:15:04]

Almost good, but I do not like the massive code duplication in the platform
ports.

https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):

https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h#newcode172
src/deoptimizer.h:172: const_reference operator[](size_t index) const { return
values_[index]; }
As discussed offline, we should not expose the values_ array because it is a
flattened array of values (i.e., fields of captured objects appear in the
array), so indexing does not do what you think it should do.

https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h#newcode174
src/deoptimizer.h:174: size_t size() const { return values_.size(); }
Remove this. You should use the GetValueCount method.

[Benedikt Meurer, 2015-06-10 11:19:51]

Yeah I don't like the duplication either, but that was the minimal amount of
time and energy required to keep Crankshaft alive. Everything else requires even
more time and energy for no use...

https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):

https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h#newcode172
src/deoptimizer.h:172: const_reference operator[](size_t index) const { return
values_[index]; }
On 2015/06/10 11:15:04, jarin wrote:
> As discussed offline, we should not expose the values_ array because it is a
> flattened array of values (i.e., fields of captured objects appear in the
> array), so indexing does not do what you think it should do.

Done.

https://codereview.chromium.org/1169103004/diff/1/src/deoptimizer.h#newcode174
src/deoptimizer.h:174: size_t size() const { return values_.size(); }
On 2015/06/10 11:15:04, jarin wrote:
> Remove this. You should use the GetValueCount method.

Done.

[Jarin, 2015-06-10 11:49:50]

lgtm

[Benedikt Meurer, 2015-06-10 11:51:06]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-06-10 11:51:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169103004/40001

[commit-bot: I haz the power, 2015-06-10 11:52:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 11:53:01]

Patchset 3 (id:??) landed as
https://crrev.com/cf21da7e485ac80b3071e477e5399a00ee2b365f
Cr-Commit-Position: refs/heads/master@{#28906}