Issue 1169073003: DevTools: deflake extensions-panel.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1169073003: DevTools: deflake extensions-panel.html (Closed)

Created:
4 years, 10 months ago by caseq

Modified:
4 years, 10 months ago

Reviewers:
dgozman, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: deflake extensions-panel.html There was a race condition between message being logged by the page reaching ConsoleView and extension code evaluating the code that clicks on the message rendered in console, so let's make both logging and clicking be driven by front-end, not the extensions code. BUG=498539 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196878

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -9 lines)			Patch
	M	LayoutTests/inspector/extensions/extensions-panel.html	View		2 chunks	+21 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169073003/1

4 years, 10 months ago (2015-06-10 15:15:49 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-10 16:21:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196878

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages